Added configuration flag to separate resources requiring elevated pri… #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vileges. This applies to both resource creation in terraform and inspec test execution. Allows org/project level testing in the future whilst ensuring the defaults work for those having project level permissions only. Signed-off-by: Stuart Paterson <[email protected]>
chris-rock
reviewed
May 17, 2018
|
|
||
| control 'gcp-generic-iam-role' do | ||
|
|
||
| impact 1.0 | ||
| title 'Ensure that the IAM role is correctly set up' | ||
|
|
||
| if gcp_enable_privileged_resources |
There was a problem hiding this comment.
I propose we use only_if here
control do
only_if { gcp_enable_privileged_resources == true}
end
There was a problem hiding this comment.
will update the tests accordingly, thanks!
added 2 commits
May 17, 2018 10:23
…01 exit code as successful in test execution by default. Signed-off-by: Stuart Paterson <[email protected]>
Signed-off-by: Stuart Paterson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…vileges. This applies to both resource creation in terraform and inspec test execution. Allows
org/project level testing in the future whilst ensuring the defaults work for those having project level permissions only.
Signed-off-by: Stuart Paterson [email protected]